taijibaga/heicode-mananger
9
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

fix(agent): default MODEL_NAME=gpt-5.4 for started agents (not template tier)

Browse Source 
Preset templates carry a Claude-style frontmatter model (opus/sonnet) which is
NOT a model on the HM gateway. Passing it as MODEL_NAME would make the agent's
model calls fail. Now MODEL_NAME defaults to the gateway model gpt-5.4
(env AGENT_RUNTIME_DEFAULT_MODEL); a non-Claude-tier template model is honored.
Tests + AM contract doc updated.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
chenchen
2026-06-04 16:25:21 +08:00
co-authored by Claude Opus 4.8
parent b33bcf90bd
commit 1d81002c2d
3 changed files with 32 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
heicode/controller/agent_template_runtime.go
+10 -2
View File
@@ -148,9 +148,17 @@ func amStartTemplateAgent(ctx context.Context, args amStartArgs) (amStartResult,
if strings.TrimSpace(args.AgentDefinition) != "" {
env["AGENT_INSTRUCTION_TEXT"] = args.AgentDefinition
}
if args.Model != "" {
env["MODEL_NAME"] = args.Model
// MODEL_NAME must be a real model on the HM gateway. Template frontmatter
// carries a Claude-style tier hint (opus/sonnet/haiku) which is NOT a gateway
// model — fall back to the gateway default (gpt-5.4, env-overridable).
modelName := common.GetEnvOrDefaultString("AGENT_RUNTIME_DEFAULT_MODEL", "gpt-5.4")
switch strings.ToLower(strings.TrimSpace(args.Model)) {
case "", "opus", "sonnet", "haiku", "claude":
// keep the gateway default
default:
modelName = strings.TrimSpace(args.Model)
}
env["MODEL_NAME"] = modelName
env["OPENAI_BASE_URL"] = publicV1BaseURL()
// NOTE: OPENAI_API_KEY is intentionally NOT injected here — the desktop
// client passes its own api_key per A2A request (CODING_A2A §7). A future
heicode/controller/agent_template_test.go
+21
View File
@@ -169,12 +169,33 @@ func TestAMStartTemplateAgent_RoundTrip(t *testing.T) {
require.Contains(t, gotBody, "AGENT_ROLE_NAME")
require.Contains(t, gotBody, "OPENAI_BASE_URL")
require.Contains(t, gotBody, "manager_deployment_id")
require.Contains(t, gotBody, `"MODEL_NAME":"gpt-5.4"`) // real gateway model
// response parsed
require.Equal(t, "ns-1", res.RuntimeID)
require.Equal(t, "https://abc.agents.example", res.Subdomain)
require.Equal(t, "running", res.Status) // defaulted
}
func TestAMStartTemplateAgent_ModelDefaultsToGateway(t *testing.T) {
var gotBody string
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
b, _ := io.ReadAll(r.Body)
gotBody = string(b)
_, _ = w.Write([]byte(`{"success":true,"data":{"namespace":"ns"}}`))
}))
defer srv.Close()
t.Setenv("AGENT_RUNTIME_BASE_URL", srv.URL)
// template frontmatter model "opus" is a Claude tier, not a gateway model.
_, err := amStartTemplateAgent(context.Background(), amStartArgs{
ManagerDeploymentID: "dep_1", UserID: "22", TemplateKey: "architect",
AgentDefinition: "x", Model: "opus",
})
require.NoError(t, err)
require.Contains(t, gotBody, `"MODEL_NAME":"gpt-5.4"`) // defaulted, not "opus"
require.NotContains(t, gotBody, `"MODEL_NAME":"opus"`)
}
func TestAMGetAgentStatus_RoundTrip(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
require.Equal(t, "/agents/rt-1", r.URL.Path)